-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_monitor_private_link_scope - api 2021-07-01-preview - ingestion and query mode access added #25763
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @KiPIDesTAN - overall looks good but i think this is a breaking change for users with these properties being optiona;?
internal/services/monitor/monitor_private_link_scope_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies @KiPIDesTAN it appears I was overzealous when doing some housekeeping in our SDK and removed the 2021-07-01-preview
version since it wasn't in use in the provider at the time.
Leaving this comment here so maintainers know not to merge until hashicorp/pandora#4134 has been merged and reincorporated in the provider.
@katbyte , any chance you can look at this again? The pandora item mentioned above has been merged back into main. |
@KiPIDesTAN could you rebase your PR on main and resolve the conflicts? I can look through this once that's done. |
…th ingestion and query mode access
…access_mode optional
da7291f
to
25c7b7f
Compare
@stephybun , thanks. Just finished the rebase and should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KiPIDesTAN. Could you take a look at the suggestions and questions left in-line? Once that's done this should be good to go.
internal/services/monitor/monitor_private_link_scope_resource.go
Outdated
Show resolved
Hide resolved
internal/services/monitor/monitor_private_link_scope_resource.go
Outdated
Show resolved
Hide resolved
"ingestion_access_mode": { | ||
Type: pluginsdk.TypeString, | ||
Optional: true, | ||
Default: string(privatelinkscopesapis.AccessModeOpen), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you confirm whether is this the default value returned by the API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct. Open ingestion mode is the default.
internal/services/monitor/monitor_private_link_scope_resource_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: stephybun <steph@hashicorp.com>
…test.go Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Community Note
Description
Updated Azure Monitor Private Link Scope to the latest API, 2021-07-01-preview, to support ingestion mode access and query mode access. Fixes #19370 and fixes #10059.
This item adds ingestion_access_mode and query_access_mode items as required items to the azurerm_monitor_private_link_scope resource.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
azurerm_monitor_private_link_scope
- support for theingestion_access_mode
andquery_access_mode
property [Attribute missing from azure monitor private link scope resource #19370]This is a (please select all that apply):
Related Issue(s)
Fixes #19370
Fixes #10059
Note
If this PR changes meaningfully during the course of review please update the title and description as required.